Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to async post #6

Merged
merged 2 commits into from
Mar 24, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 24, 2018

Minor tweaks to structure.

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 24, 2018

Rendered

screen shot 2018-03-24 at 18 14 12

screen shot 2018-03-24 at 18 14 21

screen shot 2018-03-24 at 18 14 26

screen shot 2018-03-24 at 18 14 33

screen shot 2018-03-24 at 18 14 39

@gaearon gaearon force-pushed the tweaks-async-post branch from d4711c0 to a2139de Compare March 24, 2018 18:24
Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me


## Updating class components
At Facebook, we maintain over 50,000 React components, so we're in the same boat as you. We can't rewrite our apps so we will take the gradual migration path together with everyone in the React community.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this wording, "We can't rewrite our apps". I might play with it after merging.

@bvaughn bvaughn merged commit 030980e into bvaughn:update-on-async-rendering Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants